feat(naga): constant evaluation for select
#7602
Open
+141
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
const-eval-select
branch
2 times, most recently
from
cb645c6 to
3806939
Compare
ErichDonGubler
force-pushed
the
const-eval-select
branch
from
3806939 to
27726d9
Compare
1 task
ErichDonGubler
commented
Apr 23, 2025
|
|
||
| let select_single_component = | ||
| |this: &mut Self, reject_scalar, reject, accept, condition| { | ||
| let accept = this.cast(accept, reject_scalar, span)?; |
There was a problem hiding this comment.
issue: Ah, this apparently causes a problem for one testing case where we check _ = select(true, 1, false); in validation::validation_error_messages, because cast here coerces from integrals to bool via a non-zero comparison.
I'm not sure that we should be permitting this sort of cast generally. @jimblandy, does that sound correct to do such casting? If so, I need to filter out the case of booleans specifically here...which feels wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
select#7572.Testing
Squash or Rebase?
Squash unless multiple commits.
Checklist
CHANGELOG.mdentry.