JS: Deprecate type extraction #19640
Draft
+663
−10,517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| name = spec.getExportedName() and | ||
| result = spec.getLocal() | ||
| ) | ||
| or |
Check warning
Code scanning / CodeQL
Dead code Warning
| name = sig.getName() | ||
| ) | ||
| private class MethodCallSig extends Function { | ||
| private MethodSignature signature; |
Check notice
Code scanning / CodeQL
Field only used in CharPred Note
asgerf
force-pushed
the
js/no-type-extraction
branch
from
7ba856a to
2cd92ef
Compare
Comment on lines
+10
to
+12
| /** | ||
| * Interface for accessing name-resolution info about type names. | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style. Warning
Comment on lines
+142
to
+144
| /** | ||
| * Interface for accessing name-resolution info about expressions. | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style. Warning
asgerf
force-pushed
the
js/no-type-extraction
branch
5 times, most recently
from
9521fbb to
2035925
Compare
This query depended on the cons-hashing performed by type extraction to determine if two types are the same. This is not trivial to restore, but not important enough to reimplement right now, so for now just simplifying the query's ability to recognise that two types are the same.
This was used in the very old dist-compare tool, but has no use anymore
asgerf
force-pushed
the
js/no-type-extraction
branch
from
4ba014d to
a039c1b
Compare
asgerf
force-pushed
the
js/no-type-extraction
branch
from
df2834e to
3a1fae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables type extraction by setting the default TypeScript extraction mode back to
basic, meaning only parsing is performed by the extractor.Deprecates
Typeand other APIs relating to extracted types, and introduces a simple interface for interacting with the new QL-based name/type resolution.When I made the original call graph estimated I had unfortunately not disabled the influence of type extraction completely, meaning lose more call edges than originally estimated. This PR recovers adds a few more fixes to recover some of them, but as seen in the evaluation we still lose 1 alert, and 25k call edges. I have some follow-up work with generics that recovers about a third of the call edges. Despite the lost call edges, I'd like to move ahead with this PR now so we can unblock other works that depend on it, and make sure extraction succeeds for repositories where type extraction is currently causing issues.