[lint-monster] lint-monster: workflow safe outputs largefunc slice #53269

Summary

Daily make golint-custom surfaced a concentrated long-function cluster in workflow safe outputs and adjacent compiler internals. This issue tracks one focused remediation slice from the broader function-length refactoring backlog.

Primary targets in this slice:

• pkg/workflow/safe_outputs_config_extraction.go:45 — extractSafeOutputsConfig is 376 lines
• pkg/workflow/safe_outputs_config_global.go:13 — extractGlobalConfigFields is 289 lines
• pkg/workflow/safe_outputs_max_validation.go:58 — validateSafeOutputsMax is 269 lines
• pkg/workflow/safe_outputs_config_generation.go:30 — generateSafeOutputsConfig is 196 lines
• pkg/workflow/safe_outputs_tools_computation.go:10 — computeEnabledToolNames is 188 lines

Validation command: make golint-custom

Expected outcome

Break these functions into smaller helpers with clear responsibilities so the custom largefunc linter no longer flags the addressed functions, while preserving generated workflow behavior.

Remediation checklist

• Keep remediation scoped to the workflow safe outputs cluster only.
• Prefer minimal helper extraction and local reorganization over cross-package redesign.
• Preserve current behavior and existing tests.
• Run make golint-custom after changes.
• Leave unrelated largefunc findings for other slices.

Copilot instructions

1. Focus only on the workflow safe outputs cluster listed above.
2. Extract small private helpers for parsing, field collection, validation branches, and rendering branches.
3. Avoid changing public interfaces unless required by the refactor.
4. Keep edits minimal and behavior-preserving.
5. Validate with make golint-custom before finishing.

Generated by 🧌 LintMonster · gpt54 · 19.8 AIC · ⌖ 6.72 AIC · ⊞ 5.9K · ◷

• expires on Aug 23, 2026, 6:53 PM UTC-08:00