Skip to content

Updated badges #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2019
Merged

Updated badges #143

merged 1 commit into from
Jun 29, 2019

Conversation

@GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Jun 28, 2019

No description provided.

@GrahamCampbell GrahamCampbell requested a review from lyrixx June 28, 2019 10:54
@lyrixx
Copy link
Member

lyrixx commented Jun 28, 2019

I always found theses badges awful. Most of the time they are KO. Like now 😂 travis is KO.
It does not bring anything useful. master could be broken, not a big deal.

I would go for removing all badges

@GrahamCampbell
Copy link
Member Author

GrahamCampbell commented Jun 28, 2019

I think the main purpose of the badges is not to show the build status, but to give people the information that tests are automated and the license is MIT. People like shiny things. ;)

@GrahamCampbell GrahamCampbell merged commit 1b9f3eb into master Jun 29, 2019
@GrahamCampbell GrahamCampbell deleted the badges branch June 29, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GrahamCampbell @lyrixx