Real Commit for Annotated Tag

[phpfui]

Annotated tags are first class git objects and have there own hash and entry in the git repo. As such, a tag really has two hashes, one is the hash of the tag itself. The other is the hash into the source tree that the tag points to. Prior versions of gitlib returned the commit of the tag, rather than the commit of the main source tree. This branch fixes this and gives the user the more logical commit for the tag, which is the commit of the source tree that the annotated tag points to. Lightweight tags are not first class objects and their commit points to the source tree commit. This branch makes the behavior of lightweight and annotated commits the same.

Other improvements made to get unit testing to work on Windows:

• Updated the foobar repo to use https
• Changed depreciated assertContains to assertStringContainsString for PHPUnit 9
• Made method return types compatible with latest PHPUnit
• Ignore .phpunit.result.cache
• Rewrite \Gitonomy\Git\Repository::getSize to use built in PHP functions instead of du -skc
• Rewrite testGetBodyMessage to avoid errors introduced by different git line ending checkout strategies
• Be directory separator agnostic when testing paths
• Correct testGetSize to more accurately reflect actual repo size

[GrahamCampbell]

why is this different?

[phpfui]

I fixed the double rounding issue in getSize, so I think we are good to go now. My initial attempt returned a float, which is no good, but then I guess my various attempts at rounding got out of sync. Now round at the end only.

[GrahamCampbell]

Please include the size fixes in a separate PR, so the changes are atomic.

[phpfui]

OK, will work on this tonight with new PR.

[GrahamCampbell]

Great, thanks. :)

[GrahamCampbell]

I've merged your other changes into master.

[phpfui]

Yes, I see. I'll merge into my version, see what we are at, and submit a new PR. Happy to help with this project. Good stuff! Bruce

…

On Fri, Mar 20, 2020 at 11:10 AM Graham Campbell ***@***.***> wrote: I've merged your other changes into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYW6S2TGWHEEVEWSZJX65DRIOBPNANCNFSM4LP5BPXQ> .