Fixed some code #32
Merged
Fixed some code #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Feb 11, 2013
lyrixx
commented
- Use specific exception (not every where)
- Fixed some random typos
- Fixed a Weird bug. Please the the commit fe90056
Member
Author
|
BTW, IMHO, It should be done everywhere |
Contributor
|
👍 about that, makes debugging much easier |
Member
Author
|
Last commit is not related to this pr ... |
And I changed the format or the log line of 'run command ...' To be able to copy/past the log line and execute the command.
If we use gitlib (located in /a/b/gitlib) and try to inspect a
project located in /a/b ; Gitlib will not be able to get the log
since it run a command like:
git log --working-dir /a/b/.git --working-tree /a/b log --format=%H -n 1 THEHASH -- PATH
so PATH does not exist in /a/b/gitlib/ (ie /a/b/gitlib/PATH).
so the command fails.
So i fixed it by preprend the working-dir.
Note: I think we should update all commands that use a path in arguments.
ping @alexandresalome
Member
|
OK, I managed to reproduce it. I read documentation of git, but found no information about paths, if they should be relative or absolute. Good for you to merge? |
Member
Author
|
Every things works from here. Good to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.