Skip to content

Cleanup the code #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
ichiriac opened this issue Jan 2, 2017 · 3 comments
Closed
5 tasks done

Cleanup the code #50

ichiriac opened this issue Jan 2, 2017 · 3 comments

Comments

@ichiriac
Copy link
Member

ichiriac commented Jan 2, 2017

  • Add "use strict" statement on every file
  • Check & investigate each @todo / @fixme statement
  • Pass with JSHint on every file
  • Use ES6
  • Add a transpiler for ES5 support
@ichiriac ichiriac added this to the 1.1.0 milestone Jan 2, 2017
@ichiriac ichiriac self-assigned this Jan 2, 2017
@ichiriac ichiriac modified the milestones: 1.2.0, 1.1.0 Jan 21, 2017
@ichiriac ichiriac modified the milestones: 2.1.0, 1.2.0 Mar 6, 2017
@ichiriac ichiriac modified the milestones: 2.1.0, 2.2.0 Nov 1, 2017
@ichiriac
Copy link
Member Author

Hi @czosel,

I would be really glad if you can help on this. When the project was started es6 was not mature but I agree that I should start to migrate on it.

I have no problem with ES6 (to be honest I do not like the class support as it shadows the prototypal power of JS), but I would be glad to use all ES6 goodies.

I just need to support browser with babel for example, and be compliant with node v4.

@czosel
Copy link
Collaborator

czosel commented Dec 26, 2017

Hi @ichiriac,
Awesome! I'll definitely try to make some first steps in this direction. I actually also don't like ES6 classes too much myself, but it's hard to live without many of the other features (say arrow functions). Since you have a build step already, compiling down to ES5 for support in IE11/Node v4 should be no problem. Rewriting the whole thing to ES6 is probably a big task, so I'd suggest introducing some ESLint rules that throw warnings when old syntax is found. What do you think?

@ichiriac
Copy link
Member Author

Agree with you, as sometimes big refactoring can lead to regressions. The ESLint automated check is a must have. You can start by providing just a simple configuration that checks common rules and attach it on travis build steps 😄

@ichiriac ichiriac modified the milestones: 2.2.0, 3.0.0 Dec 28, 2017
ichiriac added a commit that referenced this issue Dec 28, 2017
ichiriac added a commit that referenced this issue Dec 28, 2017
@ichiriac ichiriac removed their assignment Dec 29, 2017
ichiriac added a commit that referenced this issue Feb 20, 2018
@ichiriac ichiriac modified the milestones: 3.0.0, 3.1.0 Mar 6, 2018
@ichiriac ichiriac modified the milestones: 3.1.0, 3.0.0 - stable Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants