Use let or const instead of var #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
force-pushed
the
eslint_no_var
branch
from
8ab7670 to
ba287d4
Compare
czosel
force-pushed
the
eslint_no_var
branch
from
ba287d4 to
7b9e542
Compare
ichiriac
approved these changes
Dec 29, 2017
| * @extends {Expression} | ||
| * @property {Array|Expression} what | ||
| * @see https://wiki.php.net/rfc/argument_unpacking | ||
| */ | ||
| var Variadic = Expr.extends(function Variadic(what, location) { | ||
| const variadic = Expr.extends(function variadic(what, location) { |
There was a problem hiding this comment.
First letter of the class name should be in upper case in order to avoid confusion with functions
There was a problem hiding this comment.
of course, this was a search/replace mistake 😉
| @@ -204,28 +204,28 @@ module.exports = { | |||
| case this.tok.T_NEW: | |||
| return this.next().read_new_expr(); | |||
|
|
|||
| case this.tok.T_ISSET: | |||
| case this.tok.T_ISSET: { | |||
There was a problem hiding this comment.
why surrounding with { ... } ? It it a linter directive or is it better ?
There was a problem hiding this comment.
Yeah, eslint complains when you put let/const inside case. see https://eslint.org/docs/rules/no-case-declarations
|
😄 Thanks for the invite! |
|
You are very welcome my friend, I'm glad for your help 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.