Skip to content

refactor and test switch statement #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2019
Merged

refactor and test switch statement #383

merged 1 commit into from
Aug 31, 2019

Conversation

alexander-akait
Copy link
Collaborator

  • many tests
  • refactor
  • better error due refactor

@coveralls
Copy link

coveralls commented Aug 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.848% when pulling c75e4e7 on refactor-and-test-switch into 6481747 on master.

@ichiriac ichiriac self-requested a review August 31, 2019 01:22
@ichiriac ichiriac added this to the 3.0.0-prerelease.10 milestone Aug 31, 2019
ichiriac
ichiriac requested changes Aug 31, 2019
View reviewed changes
Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tests, just put expect as a fallback check as calling it is less effective than doing pre-checks

@ichiriac ichiriac assigned ichiriac and alexander-akait and unassigned ichiriac Aug 31, 2019
@alexander-akait alexander-akait force-pushed the refactor-and-test-switch branch from 2d48f7d to c75e4e7 Compare August 31, 2019 19:04
@alexander-akait
Copy link
Collaborator Author

@ichiriac fixed 👍

@ichiriac ichiriac merged commit f05e332 into master Aug 31, 2019
@alexander-akait alexander-akait deleted the refactor-and-test-switch branch August 31, 2019 20:36
@ichiriac ichiriac modified the milestones: 3.0.0-prerelease.10, 3.0.0 - stable Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichiriac ichiriac ichiriac requested changes

Assignees

@alexander-akait alexander-akait

Labels
None yet
Projects
None yet
Milestone
3.0.0 - stable
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-akait @coveralls @ichiriac