refactor: byRef

[alexander-akait]

/cc @ichiriac here just fix

in the next PR i want to remove byRef node and revert some changes from fbfd46f

[coveralls]

Coverage increased (+0.008%) to 95.859% when pulling 23d2743 on refactor-by-ref into 62973ef on master.

[ichiriac]

It's not ok, as you said, we stick on grammar, I need instead a new AssignRef, and not a byref property on assign

[alexander-akait]

@ichiriac hm, why? AssignRef === Assign with ref, we can reduce unnecessary nodes, php parser has many unnecessary nodes

[ichiriac]

AssignRef !== Assign - because AssignRef works only on = operators, so it's a subset of assign (without the need of operator property), also AssignRef does not have the same precedence as Assign with operator =

[alexander-akait]

ok, WIP

[ichiriac]

could you also provide a test with $foo = &$bar + 1 in order to check precedence

[alexander-akait]

@ichiriac done 👍

[ichiriac]

thanks @evilebottnawi - it's great

[alexander-akait]

@ichiriac WIP on remove unnecessary stuff for byRef node

[ichiriac]

in principle I don't use byRef node anymore, see 72cde99 - but still it may be cases where the byref syntax is too permissive

[alexander-akait]

@ichiriac i will check all 👍