Skip to content

refactor: read_internal_functions_in_yacc #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Aug 31, 2019

Just refactor for better reading and simplify for better maintenance

In some places we can see unnecessary (extra) checks, but it seems to me that support is more important than speed at the moment

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.873% when pulling b0d108e on refactor-read_internal_functions_in_yacc into 0df5a49 on master.

Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then just before validating could you try to pass a test with concatenation in order to keep track on the stack size and avoid problems. Lets say $a = 1 + 2 ... until 100 - it can be chaining functions, complex nested closures, etc ... but lets keep it simple, we should garantee to pass 100 concatenation (I've saw worse one time on a real script but I can't remember where)

@alexander-akait
Copy link
Collaborator Author

@ichiriac in acorn 😄 , when you use over +/-/etc 9k you got error, they fixed this, but i think it is not high priority right now, I would like to stabilize the parser at the beginning and then correct such errors, because they are extremely rare in current code, maybe we can merge this as is and i will investigate this in future? We can open issue about this

@ichiriac ichiriac changed the base branch from master to prettier September 17, 2019 13:54
@alexander-akait alexander-akait merged commit af39fc2 into prettier Sep 23, 2019
@alexander-akait alexander-akait deleted the refactor-read_internal_functions_in_yacc branch September 23, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants