Skip to content

feat(php8): union types with new AST node #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 25, 2021

Conversation

cseufert
Copy link
Collaborator

This implementation should have much better bacward compatiblity than the other PR i submitted.

@coveralls
Copy link

coveralls commented Mar 22, 2021

Coverage Status

Coverage decreased (-0.1%) to 96.063% when pulling ddae3e3 on moddengine:php8-union-types-v2 into 7de81ca on glayzzle:php8.

@cseufert cseufert changed the base branch from master to php8 March 24, 2021 10:27
@cseufert cseufert mentioned this pull request Mar 24, 2021
1 task
@czosel
Copy link
Collaborator

czosel commented Mar 25, 2021

Looks great! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants