Skip to content

Fix named arguments comments #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Apr 1, 2021

I finally figured out what @ichiriac meant by looking ahead in #673 (comment) 😌

cc @cseufert

@czosel czosel changed the base branch from master to php8 April 1, 2021 18:54
@coveralls
Copy link

coveralls commented Apr 1, 2021

Coverage Status

Coverage remained the same at 96.118% when pulling afe817d on czosel:fix-named-arguments-comments into dcbd0f7 on glayzzle:php8.

@czosel czosel force-pushed the fix-named-arguments-comments branch 2 times, most recently from 38f3af3 to 2a1acd4 Compare April 3, 2021 14:37
@czosel czosel requested a review from ichiriac April 3, 2021 14:41
@czosel czosel force-pushed the fix-named-arguments-comments branch from 2a1acd4 to 177699b Compare April 3, 2021 14:59
@ichiriac
Copy link
Member

ichiriac commented Apr 4, 2021

hi @czosel, I didn't had much time to check github messages, I'll be more active in few weeks. I'll take a look of your code and the last commit today.

Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect @czosel that's exactly how I would implement it

@czosel
Copy link
Collaborator Author

czosel commented Apr 4, 2021

hi @czosel, I didn't had much time to check github messages, I'll be more active in few weeks. I'll take a look of your code and the last commit today.

Hi @ichiriac, no worries at all!

When you do find the time again, it would we great if you could take a look at the other commits in the php8 branch as well (@cseufert sent several PRs), so that we can ultimately merge it into master.

@czosel czosel force-pushed the fix-named-arguments-comments branch from 177699b to afe817d Compare April 4, 2021 17:17
@ichiriac ichiriac merged commit bb89fff into glayzzle:php8 Apr 4, 2021
@ichiriac
Copy link
Member

ichiriac commented Apr 4, 2021

@czosel I'll do it an release it under 3.1 when php8 will be fully implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants