Skip to content

chore: configure CI in Github actions #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2021
Merged

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Oct 24, 2021

  • runs tests using GitHub actions
  • re-enables eslint
  • use jest coverage instead of coveralls

@czosel czosel requested a review from ichiriac October 24, 2021 13:45
@czosel czosel force-pushed the github-actions branch 2 times, most recently from 20fa783 to 427bb73 Compare October 24, 2021 14:21
@czosel
Copy link
Collaborator Author

czosel commented Oct 24, 2021

@ichiriac I usually prefer if all CI steps can be easily executed locally, because it allows quicker turnaround times and makes contributing easier. That's why I replaced coveralls with jest's coverage feature and I'd also like to propose removing codeclimate in favor of a stricter eslint config (if needed at all). What do you think?

Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we can merge it

@czosel
Copy link
Collaborator Author

czosel commented Oct 24, 2021

I'll go ahead and merge this so that we have a working CI again 🙂

@czosel czosel merged commit 966a6c2 into glayzzle:master Oct 24, 2021
@czosel czosel deleted the github-actions branch October 24, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants