Fix : Category and Type unavailable in Ticket Template selectable fields

[Lainow]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It fixes GLPI 11.0.0 ticket templates (predefined fields) #21313
• Here is a brief description of what this PR does
  In the list of fields that can be selected as Predefined/Mandatory and Hidden Fields for a Ticket Template, the category and type were no longer visible. (Whereas they were visible in version 10.)

Screenshots (if appropriate):

[cconard96]

Not sure. In GLPI 10, the behavior was:

• Predefined: Showed category and type
  

  glpi/src/ITILTemplatePredefinedField.php

  Line 288 in 9fa7b53

  $fields = $tt->getAllowedFieldsNames(true, true);

• Hidden: Did not show category and type
  

  glpi/src/ITILTemplateHiddenField.php

  Line 175 in 9fa7b53

  $fields = $tt->getAllowedFieldsNames(false);

• Mandatory: Showed category and type
  

  glpi/src/ITILTemplateMandatoryField.php

  Line 175 in 9fa7b53

  $fields = $ttm->getAllFields($tt);

  
  

  glpi/src/ITILTemplateField.php

  Line 74 in 9fa7b53

  $this->all_fields = $tt->getAllowedFieldsNames(true);

[cedric-anne]

See @cconard96 comments.

[Rom1-B]

I’m not sure modifying this function is necessary, as it is only called once and with $withtypeandcategory set to false. So, on line 144, the code remains $fields = $tt->getAllowedFieldsNames(false); as in the original version.

Suggested change

	public static function showForITILTemplate(ITILTemplate $tt, $withtemplate = 0, $withtypeandcategory = true): bool
	public static function showForITILTemplate(ITILTemplate $tt, $withtemplate = 0): bool