Skip to content

Conversation

RomainLvr
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !39261
  • Here is a brief description of what this PR does

Problem

The "My devices" dropdown loads all user devices synchronously, causing slow page loads for users with many devices and potential timeouts.

Solution

  • Implement lazy loading with AJAX endpoint for asynchronous device loading
  • Add pagination and search to handle large datasets efficiently
  • Group devices hierarchically by type for better organization

This follows GLPI's standard dropdown patterns and eliminates performance bottlenecks on ticket pages.

Screenshots (if appropriate):

Before :

image

After :

image

@RomainLvr RomainLvr self-assigned this Oct 9, 2025
@RomainLvr RomainLvr requested review from Rom1-B and stonebuzz October 9, 2025 12:33
@orthagh orthagh requested a review from flegastelois October 13, 2025 07:17
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good for me

@cedric-anne cedric-anne added this to the 10.0.21 milestone Oct 13, 2025
@cedric-anne cedric-anne force-pushed the fix/my-devices-dropdown-performance branch from 5cca694 to d5312b7 Compare October 13, 2025 13:02
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK.

Can you apply this patch on the customer's instance to get his feedback?

@RomainLvr
Copy link
Contributor Author

It seems OK.

Can you apply this patch on the customer's instance to get his feedback?

Yep 👍

@trasher
Copy link
Contributor

trasher commented Oct 13, 2025

Looks good to me as well.

Maybe could you add at least a few tests cases on the newly added method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants