Skip to content

fix(form): Forms with many destinations may overload the browser #21445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: 11.0/bugfixes
Choose a base branch
from
Open

fix(form): Forms with many destinations may overload the browser #21445

wants to merge 13 commits into from
+224 −31

Conversation

froozeify
Copy link
Member

@froozeify froozeify commented Oct 13, 2025 •
edited
Loading

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

  • It fixes GLPI11 - Forms with many destinations #21310
  • Switching to ajax request on destination page so forms with a lot of destinations don't overload the browser (with 89 destination was getting more than 250 requests on the page load)

@froozeify froozeify force-pushed the 11.0/21310-forms-with-many-destinations branch 2 times, most recently from a1c5025 to d3e2e44 Compare October 13, 2025 10:37
@froozeify froozeify force-pushed the 11.0/21310-forms-with-many-destinations branch from d3e2e44 to 6807c6e Compare October 13, 2025 10:41
@froozeify froozeify marked this pull request as ready for review October 14, 2025 09:37
@froozeify froozeify added the bug label Oct 14, 2025
@cedric-anne cedric-anne added this to the 11.0.2 milestone Oct 14, 2025
@froozeify froozeify mentioned this pull request Oct 14, 2025
Draft
3 tasks
AdrienClairembault
AdrienClairembault requested changes Oct 14, 2025
View reviewed changes
AdrienClairembault
AdrienClairembault requested changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When updating or creating a destination, it is no longer set as active after the page is reloaded.

AdrienClairembault
AdrienClairembault requested changes Oct 14, 2025
View reviewed changes
@froozeify
fix(form): Active destination was not set if it was containing only o…
5ea23a6 
…ne destination + fix test waiting for an already loaded field/tinymce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@trasher trasher Awaiting requested review from trasher

@cedric-anne cedric-anne Awaiting requested review from cedric-anne

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

11.0.2

Development

Successfully merging this pull request may close these issues.

GLPI11 - Forms with many destinations

3 participants

@froozeify @AdrienClairembault @cedric-anne