Remove confusing TrimPrefix(... git.BranchPrefix) #20369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
reviewed
Jul 14, 2022
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Jul 14, 2022
GiteaBot
added
lgtm/need 1
wxiaoguang
added
the
skip-changelog
lafriks
approved these changes
Jul 15, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #20369 +/- ##
=======================================
Coverage ? 46.92%
=======================================
Files ? 976
Lines ? 135193
Branches ? 0
=======================================
Hits ? 63438
Misses ? 63990
Partials ? 7765
Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 18, 2022
* giteaofficial/main: [skip ci] Updated licenses and gitignores Comment on PrivateUsers option for gitea.service (go-gitea#20383) [skip ci] Updated translations via Crowdin Remove confusing TrimPrefix(... git.BranchPrefix) (go-gitea#20369) Set target on create release with existing tag (go-gitea#20381) Initialize cron last (go-gitea#20373) Allow access to the Public Organization Member lists with minimal permissions (go-gitea#20330)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
Make Repository.GetDefaultBranch return the real branch name, instead of the ref name. Then there is no need to do TrimPrefix for repo.DefaultBranch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thisstrings.TrimPrefix(repo.DefaultBranch, git.BranchPrefix)seems incorrect.Therepo.DefaultBranchis already used as a branch name above, not a ref name.Make
Repository.GetDefaultBranchreturn the real branch name, instead of the ref name. Then there is no need to do TrimPrefix forrepo.DefaultBranch