Skip to content

Small refactor for loading PRs #22652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 2, 2023
Merged

Small refactor for loading PRs #22652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ec57d14
small refactor
lunny Jan 29, 2023
6338b67
Update models/issues/pull_list.go
lunny Jan 29, 2023
ccde81a
Merge branch 'main' into lunny/small_refactor
lunny Jan 30, 2023
699e1e5
Merge branch 'main' into lunny/small_refactor
lunny Jan 31, 2023
8d45c63
Merge branch 'main' into lunny/small_refactor
lunny Jan 31, 2023
ed0a758
Merge branch 'main' into lunny/small_refactor
zeripath Jan 31, 2023
366909c
Merge branch 'main' into lunny/small_refactor
zeripath Feb 1, 2023
833e260
Merge branch 'main' into lunny/small_refactor
lunny Feb 1, 2023
e9b29cf
Merge branch 'main' into lunny/small_refactor
lunny Feb 1, 2023
dae4715
Merge branch 'main' into lunny/small_refactor
delvh Feb 1, 2023
ab9c2e2
Merge branch 'main' into lunny/small_refactor
lunny Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions models/issues/pull_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,9 @@ func (prs PullRequestList) loadAttributes(ctx context.Context) error {
for i := range issues {
set[issues[i].ID] = issues[i]
}
for i := range prs {
prs[i].Issue = set[prs[i].IssueID]
for _, pr := range prs {
pr.Issue = set[pr.IssueID]
pr.Issue.PullRequest = pr // panic here means issueIDs and prs are not in sync
}
return nil
}
Expand Down
1 change: 0 additions & 1 deletion services/pull/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
}
}

pr.Issue.PullRequest = pr
notification.NotifyPullRequestSynchronized(ctx, doer, pr)
}
}
Expand Down