Alien-PIP getinstallversion() reports bad version #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we replace
distutils
withpkg_resources
as the previous is:0.37.0rc1
.I opted to use
pkg_resources
and notpackaging
because it is pre-installed on the base gobo system.The
available_versions()
try-except would always fail as it was callingsort()
on adict_keys
object, with a cast tolist
we can sort it as intended.In
Alien.py
we callAlien-NNN
and read the results fromstdout
, however we read it as a byte-array and not as a string, now we decode the byte-array as a "UTF-8" string so that we can properly compare it against the returned list of versions. This may cause issues with other locales, I'm unaware of how to detect the encoding used. I'm open to suggestions.