-
-
Notifications
You must be signed in to change notification settings - Fork 96
[Major] Drop support for versions < 8.1 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
=============================================
- Coverage 100.00% 99.56% -0.44%
- Complexity 53 89 +36
=============================================
Files 6 7 +1
Lines 146 230 +84
=============================================
+ Hits 146 229 +83
- Misses 0 1 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just left a bit comments, and this is great work, thanks a lot,
@godruoyi I've addressed all the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @simivar, LGTM
PhpSnowflakeException
- to help with thetry { } catch ()
PHP_INT_MAX
(e.g. on 32bit system) it would breakSonyflake
algorithmSolves #52