-
Notifications
You must be signed in to change notification settings - Fork 129
Formalize Erdős Problem 1107 #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+52
−0
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
31b1e9c
Formalize Erdős Problem 1107
zer-art 129b8d0
Merge branch 'main' into formalize-erdos-1107
zer-art 33163c4
Merge branch 'main' into formalize-erdos-1107
zer-art 48f2fcb
refactor(erdos-1107): use Nat.Full, add filter notation and Heath-Bro…
zer-art d4229b8
Merge branch 'formalize-erdos-1107' of https://github.com/zer-art/for…
zer-art ca24d4b
docs: improve phrasing of Heath-Brown result per review
zer-art 91a67a3
docs: improve phrasing References result per review
zer-art File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(erdos-1107): use Nat.Full, add filter notation and Heath-Bro…
…wn variant Address code review feedback from @mo271: - Replaced local `IsRPowerful` definition with `Nat.Full` imported from `ForMathlib`. - Refactored the summation property into a helper `SumOfRPowerful` to avoid code duplication. - Switched to filter notation (`∀ᶠ n in atTop`) to correctly capture the "every large integer" condition. - Added `erdos_1107.variants.two` to formally state the solved case for r=2 (Heath-Brown, 1988). - Updated docstrings and tags (added `solved` to the variant).
- Loading branch information
commit 48f2fcb0948e09a7918f52034513ca523b853a07
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.