Skip to content

fix(java): make system property accessible for native image compilation #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpeddada1 merged 3 commits into from
Feb 22, 2022
Merged

fix(java): make system property accessible for native image compilation #1694

mpeddada1 merged 3 commits into from
Feb 22, 2022

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Feb 16, 2022

Fixes #1693 ☕️

@mpeddada1 mpeddada1 requested review from a team as code owners February 16, 2022 13:36
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 16, 2022
@mpeddada1 mpeddada1 mentioned this pull request Feb 16, 2022
Merged
ansh0l
ansh0l approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Feb 22, 2022

Thank you!

@mpeddada1 mpeddada1 merged commit e3fb2b2 into main Feb 22, 2022
@mpeddada1 mpeddada1 deleted the native-system-properties branch February 22, 2022 15:07
@release-please release-please bot mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

@thiagotnunes thiagotnunes thiagotnunes approved these changes

@meltsufin meltsufin Awaiting requested review from meltsufin

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

@lesv lesv Awaiting requested review from lesv

+1 more reviewer

@ansh0l ansh0l ansh0l approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Native Image tests are failing when System Properties are used.

4 participants

@mpeddada1 @suztomo @thiagotnunes @ansh0l