Skip to content

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented May 1, 2024

This is to avoid running into conflict with the global session which may have different options (e.g. location, connection etc.) set.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This is to avoid running into conflict with the global session which may
have different options (e.g. location, connection etc.) set.
@shobsi shobsi requested review from a team as code owners May 1, 2024 20:04
@shobsi shobsi requested a review from tswast May 1, 2024 20:04
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 1, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label May 1, 2024
@tswast tswast enabled auto-merge (squash) May 1, 2024 20:07
@tswast tswast merged commit e4f13c3 into main May 1, 2024
@tswast tswast deleted the shobs-ml-connection branch May 1, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants