Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

docs: fix read_rows() docstring sample #44

Merged
merged 1 commit into from
Jun 29, 2020
Merged

docs: fix read_rows() docstring sample #44

merged 1 commit into from
Jun 29, 2020

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jun 29, 2020

Fixes #38. 🦕

This PR fixes the code sample in the read_rows() method docstring. The old sample was written for the v1beta1 client version.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2020
@plamut plamut requested a review from shollyman June 29, 2020 13:25
@plamut plamut merged commit 1ff6a08 into googleapis:master Jun 29, 2020
@plamut plamut deleted the iss-38 branch June 29, 2020 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

code example for read_rows() incorrect

3 participants

@plamut @shollyman @googlebot