Adding support for devices with long screens #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @amila93 , thanks so much for this fix! Unfortunately, when you submitted this PR, the webhook that asks contributors to sign a Contributor License Agreement wasn't successfully set up yet. It should now be set up though! Would you mind closing this pull request and resubmitting it? That way you can get the prompt to sign the Contributor License Agreement and we can merge this PR :) Sorry for the extra work this puts on you! |
|
I did sign it though. Sure I will resubmit it. No worries :) |
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix an issue where the camera preview is only covering a part of the screen, which will result an empty space on the bottom of the devices with long screens.