Skip to content

[Feature Request] unity-jar-resolver fails from the format 'groupId:artifactId:version:classifier' #416

Closed
@bhbac-nhnent

Description

@bhbac-nhnent

[REQUIRED] Please fill in the following fields:

  • Unity editor version: Unity5.6.7f1 ~ 2020.1.11f1
  • External Dependency Manager version: Tested 1.2.61.0 ~ 1.2.162
  • Source you installed EDM4U: firebase_unity_sdk_7.0.0/dotnet4/FirebaseMessaging.unitypackage
  • Features in External Dependency Manager in use: Android Resolver
  • Plugins SDK in use: Firebase
  • Platform you are using the Unity editor on: Windows 10 64bit

[REQUIRED] Please describe the issue here:

Hi.

unity-jar-resolver supports only the 'organization(groupId):package(artifactId):version' format libraries as in the comment below.
#186 (comment)

However, there is also a library in the form of 'groupId:artifactId:version:classifier' like the weibo sdk below.
https://github.com/sinaweibosdk/weibo_android_sdk#3-%E9%9B%86%E6%88%90sdk

allprojects {
    repositories {
        jcenter()
        mavenCentral()
        maven { url "https://dl.bintray.com/thelasterstar/maven/" }
    }
}
compile 'com.sina.weibo.sdk:core:4.4.3:openDefaultRelease@aar'
  1. There is no way I can define weibo sdk in MyDependencies.xml.
  2. If a library called 'A' depends on weibo sdk, if A is declared in MyDependencies.xml, unity-jar-resolver returns an error like this:
Reporting analytics data: /androidresolver/resolve/gradle/failed?autoResolution=False&useGradleDaemon=False&installAndroidPackages=True&explodeAars=True&patchAndroidManifest=True&patchMainTemplateGradle=True&localMavenRepoDir=Assets%2FGeneratedLocalRepo&useJetifier=True&gradleBuildEnabled=True&gradleTemplateEnabled=False&projectExportEnabled=False&androidAbis=armeabi-v7a&gradleVersion=5.6.4&androidGradlePluginVersion=3.6.0&numRequestedPackages=7&numMissingPackages=1&unityVersion=2020.1.11f1&unityPlatform=WindowsEditor&installSource=unitypackage&version=1.2.162&scope= 'Android Resolver: Gradle Resolve Failed'
ERROR: Resolution failed

Failed to fetch the following dependencies:
com.sina.weibo.sdk:core:+


Reporting analytics data: /androidresolver/resolve/failed?autoResolution=False&useGradleDaemon=False&installAndroidPackages=True&explodeAars=True&patchAndroidManifest=True&patchMainTemplateGradle=True&localMavenRepoDir=Assets%2FGeneratedLocalRepo&useJetifier=False&gradleBuildEnabled=True&gradleTemplateEnabled=False&projectExportEnabled=False&androidAbis=armeabi-v7a&gradleVersion=5.6.4&androidGradlePluginVersion=3.6.0&numRequestedPackages=7&unityVersion=2020.1.11f1&unityPlatform=WindowsEditor&installSource=unitypackage&version=1.2.162&scope= 'Android Resolver: Resolve Failed'
Resolution Failed.

Resolution failed

Failed to fetch the following dependencies:
com.sina.weibo.sdk:core:+


UnityEngine.Debug:LogError(Object)
Google.Logger:Log(String, LogLevel) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/Logger.cs:136)
GooglePlayServices.PlayServicesResolver:Log(String, LogLevel) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:1053)
GooglePlayServices.<ResolveUnsafe>c__AnonStorey9:<>m__0(Boolean, String) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:1911)
GooglePlayServices.<ResolveUnsafe>c__AnonStorey9:<>m__4() (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:1978)
Google.RunOnMainThread:ExecuteNext() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:486)
Google.RunOnMainThread:<ExecuteAllUnnested>m__1() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:536)
Google.RunOnMainThread:RunAction(Action) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:343)
Google.RunOnMainThread:ExecuteAllUnnested(Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:530)
Google.RunOnMainThread:PollOnUpdateUntilComplete(Func`1, Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:379)
GooglePlayServices.PlayServicesResolver:LabelAssets(IEnumerable`1, Action`1, Boolean, Action`2, Boolean, Boolean) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:2317)
GooglePlayServices.GradleResolver:ProcessAar(String) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1417)
GooglePlayServices.<ProcessAars>c__AnonStoreyB:<>m__0() (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1085)
Google.RunOnMainThread:ExecutePollingJobs() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:409)
Google.RunOnMainThread:<ExecuteAllUnnested>m__1() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:541)
Google.RunOnMainThread:RunAction(Action) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:343)
Google.RunOnMainThread:ExecuteAllUnnested(Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:530)
Google.RunOnMainThread:PollOnUpdateUntilComplete(Func`1, Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:379)
GooglePlayServices.PlayServicesResolver:LabelAssets(IEnumerable`1, Action`1, Boolean, Action`2, Boolean, Boolean) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:2317)
GooglePlayServices.GradleResolver:ProcessAar(String) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1417)
GooglePlayServices.<ProcessAars>c__AnonStoreyB:<>m__0() (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1085)
Google.RunOnMainThread:ExecutePollingJobs() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:409)
Google.RunOnMainThread:<ExecuteAllUnnested>m__1() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:541)
Google.RunOnMainThread:RunAction(Action) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:343)
Google.RunOnMainThread:ExecuteAllUnnested(Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:530)
Google.RunOnMainThread:PollOnUpdateUntilComplete(Func`1, Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:379)
GooglePlayServices.PlayServicesResolver:LabelAssets(IEnumerable`1, Action`1, Boolean, Action`2, Boolean, Boolean) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:2317)
GooglePlayServices.GradleResolver:ProcessAar(String) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1417)
GooglePlayServices.<ProcessAars>c__AnonStoreyB:<>m__0() (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1085)
Google.RunOnMainThread:ExecutePollingJobs() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:409)
Google.RunOnMainThread:<ExecuteAllUnnested>m__1() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:541)
Google.RunOnMainThread:RunAction(Action) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:343)
Google.RunOnMainThread:ExecuteAllUnnested(Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:530)
Google.RunOnMainThread:PollOnUpdateUntilComplete(Func`1, Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:379)
GooglePlayServices.PlayServicesResolver:LabelAssets(IEnumerable`1, Action`1, Boolean, Action`2, Boolean, Boolean) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:2317)
GooglePlayServices.GradleResolver:ProcessAar(String) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1417)
GooglePlayServices.<ProcessAars>c__AnonStoreyB:<>m__0() (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1085)
Google.RunOnMainThread:ExecutePollingJobs() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:409)
Google.RunOnMainThread:<ExecuteAllUnnested>m__1() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:541)
Google.RunOnMainThread:RunAction(Action) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:343)
Google.RunOnMainThread:ExecuteAllUnnested(Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:530)
Google.RunOnMainThread:PollOnUpdateUntilComplete(Func`1, Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:379)
GooglePlayServices.PlayServicesResolver:LabelAssets(IEnumerable`1, Action`1, Boolean, Action`2, Boolean, Boolean) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:2317)
GooglePlayServices.GradleResolver:ProcessAar(String) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1417)
GooglePlayServices.<ProcessAars>c__AnonStoreyB:<>m__0() (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1085)
Google.RunOnMainThread:ExecutePollingJobs() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:409)
Google.RunOnMainThread:<ExecuteAllUnnested>m__1() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:541)
Google.RunOnMainThread:RunAction(Action) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:343)
Google.RunOnMainThread:ExecuteAllUnnested(Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:530)
Google.RunOnMainThread:PollOnUpdateUntilComplete(Func`1, Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:379)
GooglePlayServices.PlayServicesResolver:LabelAssets(IEnumerable`1, Action`1, Boolean, Action`2, Boolean, Boolean) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/PlayServicesResolver.cs:2317)
GooglePlayServices.GradleResolver:ProcessAar(String) (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1417)
GooglePlayServices.<ProcessAars>c__AnonStoreyB:<>m__0() (at Z:/tmp/tmp.9ZapGH0Pls/third_party/unity/unity_jar_resolver/source/AndroidResolver/src/GradleResolver.cs:1085)
Google.RunOnMainThread:ExecutePollingJobs() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:409)
Google.RunOnMainThread:<ExecuteAllUnnested>m__1() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:541)
Google.RunOnMainThread:RunAction(Action) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:343)
Google.RunOnMainThread:ExecuteAllUnnested(Boolean) (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:530)
Google.RunOnMainThread:ExecuteAll() (at Z:/tmp/tmp.EH5aJF1Pno/third_party/unity/unity_jar_resolver/source/VersionHandlerImpl/src/RunOnMainThread.cs:512)
UnityEditor.EditorApplication:Internal_CallUpdateFunctions()

I think this is a bug in unity-jar-resolver where the 'classifier' argument is not considered, and I think it should be fixed.

Please answer the following, if applicable:

What's the issue repro rate?

  • 100%

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions