[Feature Request] unity-jar-resolver fails from the format 'groupId:artifactId:version:classifier' #416
Assignees
Labels
Comments
|
This issue does not seem to follow the issue template. Make sure you provide all the required information. |
bhbac-nhnent
changed the title
vimanyu
changed the title
|
Hi @bhbac-nhnent,
|
|
Hi @vimanyu , Weibo SDK can be declared in "*Dependencies" in two ways. A. Defining a library that has dependencies on Weibo SDK (eg gamebase-adapter-auth-weibo). <dependencies>
<androidPackages>
<androidPackage spec="com.toast.android.gamebase:gamebase-adapter-auth-weibo:2.19.0">
<repositories>
<repository>https://dl.bintray.com/thelasterstar/maven</repository>
</repositories>
</androidPackage>
</androidPackages>
</dependencies>B. Define Weibo SDK directly. And PlayServicesResolver can be used in two ways.
Result'A + 1': Success.The patched mainTemplate.gradle file is as follows. // Android Resolver Repos Start
([rootProject] + (rootProject.subprojects as List)).each {project ->
project.repositories {
maven {
url "https://dl.bintray.com/thelasterstar/maven" // Assets/TestWeibo/Editor/MyDependencies.xml:7
}
}
}
// Android Resolver Repos End
dependencies {
implementation fileTree(dir:'libs', include: ['*.jar'])
// Android Resolver Dependencies Start
implementation'com.toast.android.gamebase:gamebase-adapter-auth-weibo:2.19.0' // Assets/TestWeibo/Editor/MyDependencies.xml:7
// Android Resolver Dependencies End
**DEPS**}'A + 2': Failure.The error log is as follows. 'B + 1', 'B + 2': Failure.The PlayServicesResolver source code is supposed to parse only the version of the "group:artifact:version" format, so it seems that there is currently no way to declare "group:artifact:version:classifier".
I tried various methods as below, but none of them were successful. <dependencies>
<androidPackages>
<androidPackage spec="com.sina.weibo.sdk:core:4.4.4:openDefaultRelease@aar">
<repositories>
<repository>https://dl.bintray.com/thelasterstar/maven</repository>
</repositories>
</androidPackage>
<androidPackage spec="com.sina.weibo.sdk:core:10.10.0:openDefaultRelease@aar">
<repositories>
<repository>https://dl.bintray.com/thelasterstar/maven</repository>
</repositories>
</androidPackage>
<androidPackage spec="com.sina.weibo.sdk:core:10.10.0">
<repositories>
<repository>https://dl.bintray.com/thelasterstar/maven</repository>
</repositories>
</androidPackage>
<androidPackage spec="com.sina.weibo.sdk:core:openDefaultRelease:10.10.0">
<repositories>
<repository>https://dl.bintray.com/thelasterstar/maven</repository>
</repositories>
</androidPackage>
<androidPackage spec="com.sina.weibo.sdk:core:10.10.0:openDefaultRelease">
<repositories>
<repository>https://dl.bintray.com/thelasterstar/maven</repository>
</repositories>
</androidPackage>
</androidPackages>
</dependencies> |
google-oss-bot
added
needs-attention
|
Thanks so much for the detailed response and trying out all these cases @bhbac-nhnent! |
|
@vimanyu @chkuang-g After installing version 1.2.164, I was able to confirm that the resolver works fine without any problems. |
|
@vimanyu @chkuang-g After some testing, I found out that the functionality was not fully implemented yet. In gradle, '@ + artifactType' means 'dependency is ignored'. WITH DEPENDENCIES However, unity-jar-resolver fails if the classifier doesn't have artifactType attached. SUCCESS <dependencies>
<androidPackages>
<androidPackage spec="com.sina.weibo.sdk:core:10.10.0:openDefaultRelease@aar">
<repositories>
<repository>https://dl.bintray.com/thelasterstar/maven</repository>
</repositories>
</androidPackage>
</androidPackages>
</dependencies>FAIL <dependencies>
<androidPackages>
<androidPackage spec="com.sina.weibo.sdk:core:10.10.0:openDefaultRelease">
<repositories>
<repository>https://dl.bintray.com/thelasterstar/maven</repository>
</repositories>
</androidPackage>
</androidPackages>
</dependencies>
|
|
I posted the comment above as a new issue : #422 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
[REQUIRED] Please fill in the following fields:
Unity5.6.7f1 ~ 2020.1.11f1Tested 1.2.61.0 ~ 1.2.162firebase_unity_sdk_7.0.0/dotnet4/FirebaseMessaging.unitypackageAndroid ResolverFirebaseWindows 10 64bit[REQUIRED] Please describe the issue here:
Hi.
unity-jar-resolver supports only the 'organization(groupId):package(artifactId):version' format libraries as in the comment below.
#186 (comment)
However, there is also a library in the form of 'groupId:artifactId:version:classifier' like the weibo sdk below.
https://github.com/sinaweibosdk/weibo_android_sdk#3-%E9%9B%86%E6%88%90sdk
allprojects { repositories { jcenter() mavenCentral() maven { url "https://dl.bintray.com/thelasterstar/maven/" } } } compile 'com.sina.weibo.sdk:core:4.4.3:openDefaultRelease@aar'I think this is a bug in unity-jar-resolver where the 'classifier' argument is not considered, and I think it should be fixed.
Please answer the following, if applicable:
What's the issue repro rate?
The text was updated successfully, but these errors were encountered: