Skip to content

activating highest version in duplicate dependencies. #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 6, 2021
Merged

activating highest version in duplicate dependencies. #456

merged 10 commits into from
Aug 6, 2021

Conversation

vimanyu
Copy link
Collaborator

@vimanyu vimanyu commented Jul 29, 2021

activating only highest version in duplicate android package dependencies.

Old behavior in Gradle main template:

    compile 'com.android.support:support-annotations:26.1.0' // Assets/ExternalDependencyManager/Editor/TestDependencies.xml:4
    compile 'com.google.android.gms:play-services-base:12.0.1' // Assets/ExternalDependencyManager/Editor/TestAdditionalDuplicateDependencies.xml:3
    compile 'com.google.android.gms:play-services-base:15.0.1' // Assets/ExternalDependencyManager/Editor/TestAdditionalDependencies.xml:3
    compile 'com.google.firebase:firebase-app-unity:5.1.1' // Assets/Extern

New behavior:

    compile 'com.android.support:support-annotations:26.1.0' // Assets/ExternalDependencyManager/Editor/TestDependencies.xml:4
    // compile 'com.google.android.gms:play-services-base:12.0.1' // Assets/ExternalDependencyManager/Editor/TestAdditionalDuplicateDependencies.xml:3
    compile 'com.google.android.gms:play-services-base:15.0.1' // Assets/ExternalDependencyManager/Editor/TestAdditionalDependencies.xml:3
    compile 'com.google.firebase:firebase-app-unity:5.1.1' // Assets/Extern

Added a new integration test for this behavior and confirmed all integration tests for Android Resolver passes on Unity 2020.

@vimanyu
activating highest version in duplicate dependencies.
1453304 
Bug: 136026456
Fixes: #243

Change-Id: I98ee266f77d23077cbfd4471ae3e1dff74008a93
@vimanyu vimanyu requested a review from chkuang-g July 29, 2021 22:47
@vimanyu vimanyu self-assigned this Jul 29, 2021
chkuang-g
chkuang-g requested changes Jul 30, 2021
View reviewed changes
vimanyu added 5 commits August 3, 2021 10:19
@vimanyu
new method to get package specs and vesion metadata
de96b33 
Change-Id: Ibfe3ec241a32f84113f36811d1f4dafb4bd76a9a
@vimanyu
using new method to avoid any possibility of duplicates
6c921ec 
Change-Id: Ia4d0ddc10c6c31ce070aa0e5ac7a375ea2640fbc
@vimanyu
updated test case with a duplicate package from another source file.
7dd20e6 
Change-Id: Ie92f8e793b03e0fff4ce5ba2425b309b9dea76d7
@vimanyu
logging the duplicate package case
e3587be 
Change-Id: I18bdbd82983a9fcb995876b3d7c04eee2d00cb47
@vimanyu
added duplicate package with wildcard version.
a1992c4 
Change-Id: I79f5ab4e4fadd549df3f058c3e33934746773144
@vimanyu vimanyu requested a review from chkuang-g August 3, 2021 21:51
chkuang-g
chkuang-g requested changes Aug 5, 2021
View reviewed changes
@vimanyu vimanyu requested a review from chkuang-g August 6, 2021 03:08
chkuang-g
chkuang-g requested changes Aug 6, 2021
View reviewed changes
@vimanyu vimanyu requested a review from chkuang-g August 6, 2021 21:02
chkuang-g
chkuang-g requested changes Aug 6, 2021
View reviewed changes
@vimanyu vimanyu requested a review from chkuang-g August 6, 2021 21:13
@vimanyu vimanyu merged commit 41072ec into master Aug 6, 2021
@vimanyu vimanyu deleted the bugfix/duplicate-dependencies-gradle-template branch August 6, 2021 21:15
@googlesamples googlesamples locked and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chkuang-g chkuang-g chkuang-g approved these changes

Assignees

@vimanyu vimanyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimanyu @chkuang-g