Preserve Android plugin CPU value in exports.json for ExportUnityPackage #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkuang-g
approved these changes
Sep 13, 2023
chkuang-g
requested changes
Sep 13, 2023
| @@ -1799,6 +1848,9 @@ def importer_metadata(self): | |||
| platform_data_options["enabled"] = 1 | |||
| importer_metadata = Asset.set_cpu_for_desktop_platforms( | |||
| importer_metadata) | |||
| if "Android" in platforms: | |||
There was a problem hiding this comment.
I am debating with myself if you should only run set_cpu_for_android only if cpu_string is NOT AnyCPU.
What do you think?
There was a problem hiding this comment.
Thanks for the suggestion! I added this change with a new commit. It seems like this will avoid extra work when cpu_string is AnyCPU since it would be looping through the platforms and make no changes (based on my understanding that the Android CPU value in importer_metadata appears to be always be AnyCPU without this change). Is this what you were thinking?
chkuang-g
approved these changes
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the CPU value in the importer metadata for Android plugins when the exports.json specifies a CPU value for the Android plugin.
Fixes #638