-
Notifications
You must be signed in to change notification settings - Fork 450
Fixed assignment in if expression #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Good catch, and no, I hadn't used any static code analysis before. Please sign the CLA and I'll merge. |
I already did in 2013 :) Edit: With a different e-mail though ([email protected]). The e-mail I use for git is not tied to a Google account. Is that OK? Otherwise, I hereby declare this contribution to be public domain (in case that works out legally). |
Since it's a new email you'll need to sign it again. Please follow the links that googlebot provided above. |
I don't have a Google account on that e-mail address, and I'm not willing to register a new Google account just so that I can sign the CLA. And apparently I can only sign the CLA with a Google account, is that correct? (At least I'm always redirected to the login age.) If that's a problem for Google, then you can also close this pull request and fix it in a commit of your own. I don't care about the copyright of this commit, I release it under public domain. I just want this issue to be fixed. |
No need to make another Google account. An alternative option is to change the email used on your git commits to be the one we have a CLA for: https://help.github.com/articles/setting-your-email-in-git/ That said, I'm happy to just make the fix myself. |
CLAs look good, thanks! |
OK, amended the commit. Still, it should be possible to sign the CLA without having a Google account. |
Fixed assignment in if expression
Thx :) |
This could have been quite ugly, if this assignment were at another place.
Aren't any static code analysis tools used in the publication workflow of these libraries? I found this bug with ESLint. Especially with regard to authentication libraries, code quality needs to be high.