Skip to content

Fixed assignment in if expression #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2015

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Oct 16, 2015

This could have been quite ugly, if this assignment were at another place.

Aren't any static code analysis tools used in the publication workflow of these libraries? I found this bug with ESLint. Especially with regard to authentication libraries, code quality needs to be high.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@erickoledadevrel
Copy link
Contributor

Good catch, and no, I hadn't used any static code analysis before. Please sign the CLA and I'll merge.

@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 17, 2015

I already did in 2013 :)

Edit: With a different e-mail though ([email protected]). The e-mail I use for git is not tied to a Google account. Is that OK? Otherwise, I hereby declare this contribution to be public domain (in case that works out legally).

@erickoledadevrel
Copy link
Contributor

Since it's a new email you'll need to sign it again. Please follow the links that googlebot provided above.

@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 19, 2015

I don't have a Google account on that e-mail address, and I'm not willing to register a new Google account just so that I can sign the CLA. And apparently I can only sign the CLA with a Google account, is that correct? (At least I'm always redirected to the login age.)

If that's a problem for Google, then you can also close this pull request and fix it in a commit of your own. I don't care about the copyright of this commit, I release it under public domain. I just want this issue to be fixed.

@erickoledadevrel
Copy link
Contributor

No need to make another Google account. An alternative option is to change the email used on your git commits to be the one we have a CLA for:

https://help.github.com/articles/setting-your-email-in-git/

That said, I'm happy to just make the fix myself.

@googlebot
Copy link

CLAs look good, thanks!

@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 20, 2015

OK, amended the commit. Still, it should be possible to sign the CLA without having a Google account.

erickoledadevrel pushed a commit that referenced this pull request Oct 20, 2015
Fixed assignment in if expression
@erickoledadevrel erickoledadevrel merged commit 00794fe into googleworkspace:master Oct 20, 2015
@dbrgn dbrgn deleted the if-assignment branch October 20, 2015 16:49
@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 20, 2015

Thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants