Skip to content

Documented a few smaller functions in Readme #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Spencer-Easton
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@Spencer-Easton
Copy link
Contributor Author

signed

@@ -147,6 +147,39 @@ request in the "Authorization" header.
...
}

### 5. Reseting the Access Token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These numerical headers are meant for listing the required steps to use the library. The information you added is not required however, so I'd prefer that it was documented outside of this section. What about removing the numbering and moving these tips under a "Other features" header, etc.

@erickoledadevrel
Copy link
Contributor

Thanks for writing this up. I've added a couple of comments, and once you address them I'll happily merge this in.

@googlebot
Copy link

CLAs look good, thanks!

@Spencer-Easton
Copy link
Contributor Author

Everything should be good now. Sorry for being 'spammy' about these fixes. Just starting to diving into github as I'm writing a git tool for GAS.

erickoledadevrel pushed a commit that referenced this pull request Feb 3, 2015
Documented a few smaller functions in Readme
@erickoledadevrel erickoledadevrel merged commit b94e976 into googleworkspace:ref/heads/master Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants