Skip to content
This repository was archived by the owner on Aug 19, 2020. It is now read-only.

Add convenience method for MapProperty that was introduced in 5.1 #1307

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Add convenience method for MapProperty that was introduced in 5.1 #1307

merged 2 commits into from
Jan 8, 2019

Conversation

mkobit
Copy link
Contributor

@mkobit mkobit commented Jan 2, 2019 •
edited
Loading

Context

Similar convenience like the other *property() methods

Contributor Checklist

  • Base the PR against the develop branch
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Provide integration tests to verify changes from a user perspective
  • Provide unit tests to verify logic
  • Ensure that tests pass locally: ./gradlew check --parallel

JLLeitschuh
JLLeitschuh approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please! Do the other listProperty, setProperty methods have tests? If so, you should probably slap one in there as well.

eskatos
eskatos approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👍

@eskatos eskatos merged commit 1f7aa6b into gradle:develop Jan 8, 2019
@mkobit mkobit deleted the mk/map-property-convenience-method branch January 8, 2019 13:39
@eskatos eskatos added this to the 1.1.1 milestone Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@eskatos eskatos eskatos approved these changes

@JLLeitschuh JLLeitschuh JLLeitschuh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mkobit @eskatos @JLLeitschuh