fix: Always close database connections #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user of grafana's alloy agent noticed ( grafana/alloy#1929 ) a goroutine leak when utilizing the postgres exporter with an inaccessible postgres database. This PR appropriately closes any of the database connections that are opened, preventing the leak.
To test, I just ran the exporter using a configuration that was not valid (no postgres running on my machine), and in another terminal curled it repeatedly, monitoring the goroutine count being returned from the prometheus metrics endpoint. Running this test can very quickly show the leak, and that a build from this PR resolves the issue.