indexed argument & declared eth_calls moved/edited #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Next.js Bundle Analysis for @graphprotocol/docsThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Six Hundred Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
benface
reviewed
Jun 24, 2024
alex-pakalniskis
requested changes
Jun 26, 2024
alex-pakalniskis
requested changes
Jul 11, 2024
| eventHandlers: | ||
| - event: Transfer(indexed address,indexed address,uint256) | ||
| handler: handleTransferToOrFrom | ||
| topic1: ['0xAddressA', '0xAddressB', '0xAddressC'] # Sender or Receiver Address |
There was a problem hiding this comment.
Now that I think about it more, the comment should probably read # Sender address
| - event: Transfer(indexed address,indexed address,uint256) | ||
| handler: handleTransferToOrFrom | ||
| topic1: ['0xAddressA', '0xAddressB', '0xAddressC'] # Sender or Receiver Address | ||
| topic2: ['0xAddressB', '0xAddressC'] # Sender or Receiver Address |
There was a problem hiding this comment.
And this comment should probably read # Receiver address
|
|
||
| In this configuration: | ||
|
|
||
| - `topic1` is configured to filter `Transfer` events where `0xAddressA`, `0xAddressB`, `0xAddressC` is either the sender or the receiver. |
There was a problem hiding this comment.
Should be updated to ...is the sender.
| In this configuration: | ||
|
|
||
| - `topic1` is configured to filter `Transfer` events where `0xAddressA`, `0xAddressB`, `0xAddressC` is either the sender or the receiver. | ||
| - `topic2` is configured to filter `Transfer` events where `0xAddressB` and `0xAddressC` is either the sender or the receiver. |
There was a problem hiding this comment.
Should be updated to ...is the receiver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Edited and moved Index arguments/topic filters and declared eth_call section to "Subgraph Manifest" section
-moved timeseries and aggregations
-deleted ipfs-on-ethereum-contracts
-changed file data sources title-->ipfs/Arweave File Data Sources
@alex-pakalniskis please review :)
@yash251 one task down