Skip to content

Move source-modifying scripts out of prebuild to avoid unintentionally running them locally #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Move source-modifying scripts out of prebuild to avoid unintentionally running them locally #911

merged 2 commits into from
Mar 31, 2025

Conversation

benface
Copy link
Contributor

@benface benface commented Mar 31, 2025

As proposed here.

@benface benface requested a review from a team as a code owner March 31, 2025 17:13
MichaelMacaulay
MichaelMacaulay approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@MichaelMacaulay MichaelMacaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MichaelMacaulay
MichaelMacaulay approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@MichaelMacaulay MichaelMacaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benface benface merged commit 2f572c7 into main Mar 31, 2025
4 checks passed
@benface benface deleted the benface/prebuild-scripts branch March 31, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMacaulay MichaelMacaulay MichaelMacaulay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benface @MichaelMacaulay