Skip to content

docs: Updating Discord popular channels #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2021
Merged

docs: Updating Discord popular channels #1034

merged 2 commits into from
Apr 5, 2021

Conversation

Urigo
Copy link
Contributor

@Urigo Urigo commented Apr 4, 2021 •
edited
Loading

@benjie @brianwarner a first try at this, not sure if it's the best but let's have the discussion over this PR

@Urigo
docs: Updating Discord popular channels
daccf13 
@benjie @brianwarner first try, not sure if that's the best way to organize it, let's have the discussion over this PR
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 4, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@Urigo Urigo requested review from brianwarner and benjie April 4, 2021 14:16
@benjie
Copy link
Member

benjie commented Apr 4, 2021

I think Graphile should probably be moved under the Vendors section; I’m happy wit the other changes though.

@Urigo
Copy link
Contributor Author

Urigo commented Apr 4, 2021

@benjie do you think The Guild one should also be moved?
it suppose to be general GraphQL but it's ran by us and I guess we are a vendor?

@Urigo
Copy link
Contributor Author

Urigo commented Apr 5, 2021

ok I've moved Graphile to vendors.
I've left The Guild in general Discord because that's the actual purpose of the server, not things that are specific for The Guild (and also if one day we'll have an official GraphQL Discord we'll just move everything there).

I've placed Graphile above Prisma because Prisma is no longer GraphQL focused so I think it makes more sense for the user.

@brianwarner @benjie let me know if everything looks ok and I can merge.

@brianwarner
Copy link
Contributor

Looks good to me, and I'm glad to see we are continuing to refine these pages after taking them live. Thanks @Urigo!

@brianwarner brianwarner merged commit 6908ac9 into source Apr 5, 2021
@benjie benjie deleted the Urigo-patch-1 branch April 5, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

@brianwarner brianwarner Awaiting requested review from brianwarner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Urigo @benjie @brianwarner