Skip to content

Brand Guidelines #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Brand Guidelines #1084

merged 1 commit into from
Aug 26, 2021

Conversation

leebyron
Copy link
Collaborator

Adds a page outlining brand and trademark guidelines, includes updated polished assets with corrected colors.

Updates assets in use and links into brand.

@leebyron leebyron requested review from orta and brianwarner August 24, 2021 18:43
@leebyron leebyron force-pushed the brand-guidelines branch 4 times, most recently from 544c28f to b50913b Compare August 24, 2021 22:23
Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview: https://deploy-preview-1084--graphql-org.netlify.app/brand

I love the page, it's great. Forcing the acknowledgement is an interesting call, wonder what that looks like in the long run.

For TypeScript's branding page, I tried to make sure that the wording and descriptions would hit search queries like "typescript logo" etc, might be worth a think if there's ways to do the same here

Only thing I'm a bit eh on is that the link lives under the GraphQL foundation in the footer, it feels like that would be the branding guidelines for the foundation and not necessarily for GraphQL (and thus have the useful design assets folks are after.)

Either way, very cool

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple minor notes 👍

@leebyron
Copy link
Collaborator Author

Great feedback, thanks both of you!

Such a good point about SEO and key terms. I did a bit of rephrasing to hopefully do a better job of that. I also just pulled out a separate PR I'll rebase over in #1089 which gives this a clearer place in the footer.

@leebyron leebyron force-pushed the brand-guidelines branch 2 times, most recently from 0b2863a to fe96025 Compare August 26, 2021 19:30
Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, solid improvement 👍🏻

@leebyron leebyron force-pushed the brand-guidelines branch 2 times, most recently from 947c601 to a969c9c Compare August 26, 2021 20:40
Updates assets in use and links into brand
@leebyron leebyron merged commit 1d40870 into source Aug 26, 2021
@leebyron leebyron deleted the brand-guidelines branch August 26, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants