-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Brand Guidelines #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brand Guidelines #1084
Conversation
544c28f
to
b50913b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview: https://deploy-preview-1084--graphql-org.netlify.app/brand
I love the page, it's great. Forcing the acknowledgement is an interesting call, wonder what that looks like in the long run.
For TypeScript's branding page, I tried to make sure that the wording and descriptions would hit search queries like "typescript logo" etc, might be worth a think if there's ways to do the same here
Only thing I'm a bit eh on is that the link lives under the GraphQL foundation in the footer, it feels like that would be the branding guidelines for the foundation and not necessarily for GraphQL (and thus have the useful design assets folks are after.)
Either way, very cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple minor notes 👍
b50913b
to
ba7a94a
Compare
Great feedback, thanks both of you! Such a good point about SEO and key terms. I did a bit of rephrasing to hopefully do a better job of that. I also just pulled out a separate PR I'll rebase over in #1089 which gives this a clearer place in the footer. |
0b2863a
to
fe96025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, solid improvement 👍🏻
947c601
to
a969c9c
Compare
Updates assets in use and links into brand
a969c9c
to
d3d66d7
Compare
Adds a page outlining brand and trademark guidelines, includes updated polished assets with corrected colors.
Updates assets in use and links into brand.