Skip to content

Add community grant report for May-July 2022 #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 3, 2023

@leebyron This is the blog post you reviewed back in October with some very minor edits (and I've added some subtitles to space out the text a little). I've added a little entry quote block to set some context, do you think that sets the right tone? Sorry it took so long to get around to raising the PR, it's been hectic 😅

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 3, 2023

✅ graphql.github.io-source deploy preview ready

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 3, 2023

✅ graphql.github.io-source deploy preview ready

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @benjie! 🎉 🙇

@leebyron
Copy link
Collaborator

leebyron commented Feb 3, 2023

This is awesome, thank you Benjie! I agree with the small suggestions from @hwillson then otherwise consider this a 👍 to merge when you're ready to do so!

Though also to be clear, very happy you're asking for feedback, but you do not need my approval to ship blog posts :)

@benjie
Copy link
Member Author

benjie commented Feb 4, 2023

Thanks for the feedback Hugh, all integrated 👍

Thanks Lee! Yeah, it was mostly that I wanted to make sure you felt the entry block quote was setting the right tone, since I figure that will likely be used again on other people's grant reports in future 😁

@benjie
Copy link
Member Author

benjie commented Feb 4, 2023

Oh, @hwillson, I used the tag "grants" which is new - does that seem right or should we go with an established tag like "blog" or something?

@benjie
Copy link
Member Author

benjie commented Feb 4, 2023

Netlify was giving me issues on a GraphQL.js PR yesterday too... I don't know what's up with it, seems some sporadic GitHub failures perhaps?

@hwillson
Copy link
Member

hwillson commented Feb 7, 2023

@benjie using grants for the tag looks great. I'll try re-running the jobs to see if we're in the clear now.

@hwillson hwillson force-pushed the grant-report-july-2022 branch from 6968a75 to 3685d3b Compare February 7, 2023 00:57
@hwillson
Copy link
Member

hwillson commented Feb 7, 2023

@benjie rebasing fixed the Netlify issue and the preview looks good. I'll go ahead and merge. Thanks!

@hwillson hwillson merged commit 9bcfe2d into source Feb 7, 2023
@hwillson hwillson deleted the grant-report-july-2022 branch February 7, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants