Skip to content

Correct ofType name forid to be ID #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2016
Merged

Correct ofType name forid to be ID #191

merged 1 commit into from
Oct 31, 2016

Conversation

eventualbuddha
Copy link
Contributor

I'm not sure I understand, but in the example after this they do includeofType and end up with this:

{
          "name": "id",
          "type": {
            "name": null,
            "kind": "NON_NULL",
            "ofType": {
              "name": "ID",
              "kind": "SCALAR"
            }
          }
        },

Note that not the name nor the kind isString.

@stubailo stubailo merged commit 4e9d192 into graphql:source Oct 31, 2016
@stubailo
Copy link
Contributor

Thanks!

Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
@eventualbuddha
Correct ofType name forid to be ID (graphql#191)
94bbc00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eventualbuddha @stubailo @facebook-github-bot