Skip to content

Make sure that broken syntax blows up in Travis #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2017
Merged

Make sure that broken syntax blows up in Travis #307

merged 1 commit into from
May 1, 2017

Conversation

wincent
Copy link
Contributor

@wincent wincent commented May 1, 2017

Will prevent issues like this from happening again:

Note that we fail loudly in build but not in watch (where we want to give the user a chance to correct their error).

Tested by manually adding and removing syntax errors when doing npm run build and npm run watch.

@wincent
Make sure that broken syntax blows up in Travis
bdf8894 
Will prevent issues like this from happening again:

- #304
- #305

Note that we fail loudly in `build` but not in `watch` (where we want to
give the user a chance to correct their error).

Tested by manually adding and removing syntax errors when doing `npm run
build` and `npm run watch`.
@wincent wincent merged commit 03bfb16 into graphql:source May 1, 2017
@wincent wincent deleted the glh/explode branch May 1, 2017 22:54
Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
@wincent
Merge pull request graphql#307 from wincent/glh/explode
6916ef2 
Make sure that broken syntax blows up in Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wincent @facebook-github-bot