Order languages alphabetically on /code #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts the language sections in order as suggested in: #332 Additionally, it adds small tables of contents at the top of each major section to make it easier to locate and jump to specific language implementations. I maintained a special call-out to the JavaScript reference implementations because we want them to be fairly prominent (this is why they were at the top in originally). Manually tested that the links work by running a local build. Note that there is some fragility here in that the links are hand-constructed and depend on the ordering within the page (ie. the server JavaScript link it "#javascript" but the client one is "#javascript-1" because it appears further down the page); wanted to do the simplest thing for now and deal with any breakage later IFF it ever happens.
Dipeshwagle
pushed a commit
to Dipeshwagle/graphql.github.io
that referenced
this pull request
Aug 18, 2020
Order languages alphabetically on /code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts the language sections in order as suggested in:
#332
Additionally, it adds small tables of contents at the top of each major section to make it easier to locate and jump to specific language implementations. I maintained a special call-out to the JavaScript reference implementations because we want them to be fairly prominent (this is why they were at the top in originally).
Manually tested that the links work by running a local build. Note that there is some fragility here in that the links are hand-constructed and depend on the ordering within the page (ie. the server JavaScript link it "#javascript" but the client one is "#javascript-1" because it appears further down the page); wanted to do the simplest thing for now and deal with any breakage later IFF it ever happens.