Skip to content

Fix API Reference on return type of execute #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

brabeji
Copy link
Contributor

@brabeji brabeji commented Dec 19, 2017

API Reference incorrectly states that return type of execute is always a Promise
https://github.com/graphql/graphql-js/blob/8173c24dba61c5e032e4abd518729a5591b3076c/src/execution/execute.js#L147

API Reference incorrectly states that return type of `execute` is always a `Promise`
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@brabeji brabeji changed the title Fix docs on return type of execute Fix API Reference on return type of execute Dec 19, 2017
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron leebyron merged commit 7c22bce into graphql:source Jun 29, 2018
Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
API Reference incorrectly states that return type of `execute` is always a `Promise`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants