Skip to content

FileJet image optimization for "users" page #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

ivanbarlog
Copy link
Contributor

@ivanbarlog ivanbarlog commented Mar 23, 2019

We at FileJet love your project so we have decided that we will help you to optimize your "users" page.

Size matters!

Hence we are caching your images by our smart CDN which resizes them based on your CSS media queries so your users won't download billboard sized images to their mobile devices ;-)

Here is your traffic (throttled for Fast 3G) without FileJet usage:

without-filejet

And of course with using the FileJet:

with-filejet

You can find full report at filejet.io/inspector

We also wanted to add onError for serving the original images but it seems that it's being removed from the DOM on compilation 😞 It would look something like this:

onError={(e)=>{e.target.onerror = null; e.target.src=`https://graphql.github.io/users/logos/${logo.img}`}}

Since we love your product so much we are giving this to you for free :-)

Your domain (graphql.github.com) has been white-listed so you can use it at other pages as well if you wish. We can even help you implement it if you wish.

With ❤️ by FileJet

@ivanbarlog
Copy link
Contributor Author

Ping :octocat: @JoelMarcey @caniszczyk

@JoelMarcey
Copy link
Contributor

I added who I think are two appropriate reviewers for this.

@ivanbarlog
Copy link
Contributor Author

@leebyron @caniszczyk any progress on reviewing this PR? :octocat:

@leebyron leebyron merged commit 5688ec7 into graphql:source Sep 4, 2019
@leebyron
Copy link
Collaborator

leebyron commented Sep 4, 2019

Cool!

@ivanbarlog
Copy link
Contributor Author

ivanbarlog commented Sep 4, 2019

Thank you @leebyron

Here is the new report: https://filejet.io/inspector/result/hueua0ki6shyijr684p4944jftqkqaqe

And also we have written about you

Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants