Skip to content

temporary redirect until we figure out the swapi-graphql issue #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

acao
Copy link
Member

@acao acao commented Jun 8, 2019

No description provided.

@acao acao changed the title temporary oops page until we figure this out temporary oops page until we figure out the swapi-graphql issue Jun 8, 2019
@acao acao force-pushed the temp-demo-link branch from c255054 to 51e503e Compare June 8, 2019 18:23
@acao
Copy link
Member Author

acao commented Jun 8, 2019

actually, we decided on another approach, revising this, hold up!

@acao acao force-pushed the temp-demo-link branch from 51e503e to f11410a Compare June 8, 2019 19:28
@acao
Copy link
Member Author

acao commented Jun 8, 2019

IMHO, the redirect component should use window.location.replace() so as to rewrite browser history, but thats for another PR

@acao acao changed the title temporary oops page until we figure out the swapi-graphql issue temporary redirect until we figure out the swapi-graphql issue Jun 8, 2019
@caniszczyk caniszczyk merged commit 357ddb4 into graphql:source Jun 10, 2019
Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
temporary redirect until we figure out the swapi-graphql issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants