add trailing slashes to prevent github.io 301, splat for query params #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoelMarcey @caniszczyk this should be the permanent fix, if you have time to review please! |
Dipeshwagle
pushed a commit
to Dipeshwagle/graphql.github.io
that referenced
this pull request
Aug 18, 2020
add trailing slashes to prevent github.io 301, splat for query params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ope! After talking to Netlify support who's been super helpful, he pointed out that we are pointing to a githubpages path that forces a 301 redirect. Adding the trailing slash should fix this, as github.io will send a 200 for graphql.github.io/swapi-graphql/ and a 301 for graphql.github.io/swapi-graphql to the latter.
(added) a splat for QPs as well, such as
graphql.org/swapi-graphql/?query=234234234.this should hopefully fix legacy links, where folks have GraphQL query examples/etc that point to this domain