Skip to content

better redirects using 301 HTTP code #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Conversation

acao
Copy link
Member

@acao acao commented Jun 11, 2019

handy as a point of reference, and cleans up the filesystem a bit too

now that we have _redirects in place and we know its working, I thought I'd go all out.

there was almost a chance to do this more dynamically, but there were enough subtle differences that i made it very static

believe it or not, I read somewhere that google does indeed handle these soft JS redirects like they're 301's sometimes! poor google :/

should I also drop the Redirect.js react component, because it's no longer used? maybe document somewhere in Contributing.md how to add redirects too?

@acao
Copy link
Member Author

acao commented Feb 22, 2020

@orta fyi this is a pretty straightforward PR that should reduce the bloat of these additional files/directories

@orta
Copy link
Member

orta commented Feb 22, 2020

Perfect, let's get this in.

@orta orta merged commit 2dd0844 into graphql:source Feb 22, 2020
Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
better redirects using 301 HTTP code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants