Skip to content

Update Learn-Queries.md #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Learn-Queries.md #844

wants to merge 1 commit into from

Conversation

leventov
Copy link
Contributor

In sentence

When something goes wrong either in your network logs or your GraphQL server, it is easier to identify a query in your codebase by name instead of trying to decipher the contents.

Removed the word "logs" because it looks like it doesn't belong to this sentence.

@orta
Copy link
Member

orta commented Feb 25, 2020

Thanks for the PR and helping to improve the docs, but I think it makes more sense with the word logs in.

  • With: If you have problems look at your network logs: see what the response to your query is

  • Without: If you have problems look at your network: check computer is connected to the net

@orta orta closed this Feb 25, 2020
@leventov
Copy link
Contributor Author

I see what was meant now, but it's not obvious meaning. Suggested the following:

"When something goes wrong (you see errors either in your network logs, or the logs of your GraphQL server) it is easier to identify a query in your codebase by name instead of trying to decipher the contents."

@orta WDYT?

@leventov leventov deleted the patch-2 branch February 26, 2020 07:18
@orta
Copy link
Member

orta commented Feb 26, 2020

Yep 👍

leventov added a commit to leventov/graphql.github.io that referenced this pull request Feb 27, 2020
@leventov leventov mentioned this pull request Feb 27, 2020
Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants