Fix URL to GitHub public GraphQL API #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the original link took users to a page that had a header reading `The content on this site may be out of date. For the most accurate and up-to-date content` and directed them to go to the new link
carolstran
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Nice catch @its-a-lisa-at-work and thanks for taking care 🎊
My only suggestion would be to have a bit more specific commit message (ie instead of Update index.html.js it could be Update GitHub link in index.html.js.
Pinging @IvanGoncharov to merge!
|
Thanks! I appreciate that feedback; this was my first commit to a community
repo, so that is a great recommendation and something I'll remember and try
to catch going forward.
…On Thu, Aug 20, 2020 at 9:45 AM Carolyn Stransky ***@***.***> wrote:
***@***.**** approved this pull request.
Nice catch @its-a-lisa-at-work <https://github.com/its-a-lisa-at-work>
and thanks for taking care 🎊
My only suggestion would be to have a bit more specific commit message (ie
instead of Update index.html.js it could be Update GitHub link in
index.html.js.
Pinging @IvanGoncharov <https://github.com/IvanGoncharov> to merge!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#901 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPQBHQD5JRQ5REKOXZ3TBLSBUSJBANCNFSM4PKCD6UA>
.
--
Alyssa Feola
Cybersecurity Advisor
Technology Portfolio
GSA | FAS | TTS | QQ3
[email protected]
cell: 202-322-8267
|
IvanGoncharov
changed the title
ardatan
added a commit
to ardatan/graphql.github.io
that referenced
this pull request
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the original link took users to a page that had a header reading
The content on this site may be out of date. For the most accurate and up-to-date contentand directed them to go to the new link