Skip to content

Create Frequently Asked Questions (FAQ) Page #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Create Frequently Asked Questions (FAQ) Page #942

merged 2 commits into from
Nov 13, 2020

Conversation

carolstran
Copy link
Member

@carolstran carolstran commented Nov 2, 2020

💓 This PR is part of Google Season of Docs 💓

Initial technical implementation of the FAQ page, as well as the first 10 questions that were reviewed and approved in #943. We will continue to update the design, SEO, content, etc. in future PRs.
Note: Original iteration was done on #929 but updated due to the Gatsby migration.

Current status:

  • FAQ link added to the header nav
  • Questions and answers fully visible on the page (with questions listed at the top)

Current design:
Initial implementation of the FAQ page

@carolstran carolstran added 🚧 In progress 💬 FAQ Related to the FAQ project for Google Season of Docs. labels Nov 2, 2020
@carolstran carolstran self-assigned this Nov 2, 2020
* Initial commit following Gatsby migration and review from #930

* Update FAQ based on feedback from Andreas

* Apply suggestions from Benjie's code review

Co-authored-by: Benjie Gillam <[email protected]>

* Update license attribution

Co-authored-by: Benjie Gillam <[email protected]>

* Add prereq note to learn question

* Update foundation numbers

* Update JS question based on Ivan's review

Co-authored-by: Benjie Gillam <[email protected]>
@carolstran carolstran marked this pull request as ready for review November 13, 2020 13:58
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Disclaimer: I have almost zero knowledge of frontend 😞

@carolstran
Copy link
Member Author

No problem @IvanGoncharov! This PR only adds a new Gatsby page based on the existing page structures in this repo, nothing fancy 😊

@carolstran carolstran requested a review from orta November 13, 2020 14:31
@carolstran
Copy link
Member Author

@orta tagging you as I'm not sure what the process is for deploying a new page, so any insights are appreciated 😇

@carolstran carolstran merged commit 6339243 into source Nov 13, 2020
@carolstran carolstran deleted the faq branch November 13, 2020 19:43
@carolstran
Copy link
Member Author

LOL nevermind @orta, just realized it deploys automatically!

Urigo pushed a commit that referenced this pull request Jan 26, 2021
* Initial commit of FAQ page

* Add answers for initial FAQ (#943)

* Initial commit following Gatsby migration and review from #930

* Update FAQ based on feedback from Andreas

* Apply suggestions from Benjie's code review

Co-authored-by: Benjie Gillam <[email protected]>

* Update license attribution

Co-authored-by: Benjie Gillam <[email protected]>

* Add prereq note to learn question

* Update foundation numbers

* Update JS question based on Ivan's review

Co-authored-by: Benjie Gillam <[email protected]>

Co-authored-by: Benjie Gillam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 FAQ Related to the FAQ project for Google Season of Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants