Skip to content

Re-add NGraphQL link in Code page (for .NET) #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 25, 2020
Merged

Re-add NGraphQL link in Code page (for .NET) #976

merged 5 commits into from
Nov 25, 2020

Conversation

rivantsov
Copy link
Contributor

No description provided.

@carolstran
Copy link
Member

@orta can correct me if I'm wrong, but I believe with the new Code page we'd prefer if you write a short description or code sample when adding a new library to the list 😊

@rivantsov
Copy link
Contributor Author

thank you. I was thinking about adding code snippet, but unfortunately, by design (and .NET nature), the smallest possible setup involves about half a dozen classes. NGraphQL does not support schema-first, only code first (by design), and this requires more than a few lines. I will add code snippet later to client library reference.
I suggest you guys do not focus too much on code snippets. Not all languages are like JavaScript and offer a trivial sample. - which is not necessarily disadvantage.
To expand on description - I don't know, the essence is there in this sentence - library for building GraphQL servers. All I can add is marketing fluff.
Also guys, please do not put too much weight on this description. In general, no serious developer will make a choice based on just reading this short description or snippets on your page. He/she will inspect ALL links in details, downloading the code and spending quite a lot of time on each solution. The description on your site could only impact the order in which he'd go thru the list, but not the process or final decision.
thank you.

@rivantsov
Copy link
Contributor Author

I added a few sentences to description.
thank you

@orta
Copy link
Member

orta commented Nov 25, 2020

Yeah, we'd prefer it to be enough so that someone doesn't have to click through to make a decision. Showing the API usage isn't really marketing fluff IMO. Given you have opinions against it, I don't see it as too much of a blocker though 👍

@orta orta merged commit c15928e into graphql:source Nov 25, 2020
@rivantsov
Copy link
Contributor Author

thanks so much, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants